-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] PSR-4 support #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you have made good progress here. I didn't run the code yet and looking through the files, everything seems fine except one "irregularity" that I spotted.
I see you marked this PR as WIP. How much is there still to do before it's ready for a final review and merge?
@@ -22,7 +21,7 @@ class PostHog_Client { | |||
*/ | |||
public function __construct($apiKey, $options = array()) { | |||
$consumers = array( | |||
"socket" => "PostHog_Consumer_Socket", | |||
"socket" => "Socket", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come this is renamed but the other ones aren't?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way we are working with the classes here is not-optimal, I have to rewrite most of it but I ran "out of budget" for this PR.
This got merged with #9, so closing. |
ref: #3