[WIP] PSR-4 support #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusandra
reviewed
Jul 15, 2020
There was a problem hiding this comment.
Looks like you have made good progress here. I didn't run the code yet and looking through the files, everything seems fine except one "irregularity" that I spotted.
I see you marked this PR as WIP. How much is there still to do before it's ready for a final review and merge?
| @@ -22,7 +21,7 @@ class PostHog_Client { | |||
| */ | |||
| public function __construct($apiKey, $options = array()) { | |||
| $consumers = array( | |||
| "socket" => "PostHog_Consumer_Socket", | |||
| "socket" => "Socket", | |||
There was a problem hiding this comment.
How come this is renamed but the other ones aren't?
There was a problem hiding this comment.
The way we are working with the classes here is not-optimal, I have to rewrite most of it but I ran "out of budget" for this PR.
Merged
|
This got merged with #9, so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #3