Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow widget surveys to be repeated indefinitely #1752

Merged

Conversation

lucasheriques
Copy link
Contributor

@lucasheriques lucasheriques commented Feb 19, 2025

Changes

add a new check for surveys repeating: if theyir type is Widget and the schedule is Always

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@lucasheriques lucasheriques added the bump minor Bump minor version when this PR gets merged label Feb 19, 2025
@lucasheriques lucasheriques self-assigned this Feb 19, 2025
@lucasheriques lucasheriques requested a review from a team as a code owner February 19, 2025 14:17
Copy link

vercel bot commented Feb 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Feb 19, 2025 5:48pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here: app.greptile.com/review/github.

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

github-actions bot commented Feb 19, 2025

Size Change: +1.44 kB (+0.04%)

Total Size: 3.31 MB

Filename Size Change
dist/all-external-dependencies.js 216 kB +129 B (+0.06%)
dist/array.full.es5.js 269 kB +100 B (+0.04%)
dist/array.full.js 372 kB +125 B (+0.03%)
dist/array.full.no-external.js 371 kB +125 B (+0.03%)
dist/array.js 184 kB +81 B (+0.04%)
dist/array.no-external.js 182 kB +81 B (+0.04%)
dist/main.js 184 kB +142 B (+0.08%)
dist/module.full.js 372 kB +146 B (+0.04%)
dist/module.full.no-external.js 371 kB +146 B (+0.04%)
dist/module.js 184 kB +102 B (+0.06%)
dist/module.no-external.js 182 kB +102 B (+0.06%)
dist/surveys-preview.js 69.8 kB +56 B (+0.08%)
dist/surveys.js 72.9 kB +109 B (+0.15%)
ℹ️ View Unchanged
Filename Size
dist/customizations.full.js 14 kB
dist/dead-clicks-autocapture.js 14.5 kB
dist/exception-autocapture.js 9.51 kB
dist/external-scripts-loader.js 2.64 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/tracing-headers.js 1.76 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

@lucasheriques lucasheriques merged commit a5df69b into main Feb 20, 2025
26 checks passed
@lucasheriques lucasheriques deleted the feat/allow-widget-surveys-to-be-repeated-indefinitely branch February 20, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants