-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support loading masking remotely #1734
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: +7.58 kB (+0.23%) Total Size: 3.32 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR adds remote configuration support for session recording masking options in PostHog's JavaScript SDK, allowing masking settings to be controlled from the server side.
- Added new constant
SESSION_RECORDING_MASKING
insrc/constants.ts
for storing server-side masking configuration - Extended
RemoteConfig
interface insrc/types.ts
to include optional masking property for server configuration - Implemented masking getter in
SessionRecording
class that combines client and server configurations, with client settings taking precedence - Added comprehensive tests verifying masking behavior across different server/client configuration scenarios
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
@pauldambra not sure why safari is failing here, seems unrelated... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks correct to me... You could add a playwright test to prove that remote config applies
Changes
Add support for setting up session replay masking in remote config / decide
Checklist