Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: silence survey logging #1707

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

marandaneto
Copy link
Member

Changes

Follow up #1679

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@marandaneto marandaneto requested a review from a team as a code owner January 30, 2025 22:15
Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Jan 30, 2025 10:27pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Removed an informational log message from src/posthog-surveys.ts that was indicating when surveys were already loaded, reducing unnecessary console output while maintaining all critical logging.

  • Removed 'Surveys already loaded, using existing data.' log statement from getSurveys method in PostHogSurveys class
  • Keeps all error and warning logs intact for proper debugging capabilities

💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

Size Change: -560 B (-0.02%)

Total Size: 3.3 MB

Filename Size Change
dist/array.full.es5.js 267 kB -56 B (-0.02%)
dist/array.full.js 370 kB -56 B (-0.02%)
dist/array.full.no-external.js 369 kB -56 B (-0.02%)
dist/array.js 183 kB -56 B (-0.03%)
dist/array.no-external.js 181 kB -56 B (-0.03%)
dist/main.js 183 kB -56 B (-0.03%)
dist/module.full.js 370 kB -56 B (-0.02%)
dist/module.full.no-external.js 369 kB -56 B (-0.02%)
dist/module.js 183 kB -56 B (-0.03%)
dist/module.no-external.js 181 kB -56 B (-0.03%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 215 kB
dist/customizations.full.js 13.8 kB
dist/dead-clicks-autocapture.js 14.5 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.64 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 69.4 kB
dist/surveys.js 72.4 kB
dist/tracing-headers.js 1.76 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

@lucasheriques lucasheriques merged commit c46550a into main Jan 30, 2025
29 checks passed
@lucasheriques lucasheriques deleted the fix/survey-logging-silence branch January 30, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants