-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: should use event listener #1701
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Modified event listener implementation in surveys component to use a custom addEventListener
utility instead of direct window event listeners, addressing pnpm build/lint issues.
- Changed
window.addEventListener
to customaddEventListener
utility insrc/extensions/surveys.tsx
for URL change events - Added cleanup of event listeners in component unmount
- Maintains same event handling functionality while resolving pnpm compatibility concerns
- Ensures consistent event listener behavior across different environments
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Size Change: -224 B (-0.01%) Total Size: 3.28 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahn, is this new code? It must've been commited after I started my branch or else my code would've gotten it
learned something new today 🤔 @rafaeelaudibert yup it's my code, merged on a PR yesterday |
or else the pnpm complains