-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improved various bundles #1265
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @benjackwhite! 👋 |
Size Change: -135 kB (-10.83%) 👏 Total Size: 1.11 MB
ℹ️ View Unchanged
|
"main": "dist/main.js", | ||
"module": "dist/module.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ELI5?
(i have managed to ignore changes to JS bundling over the last few chaotic years 🤣)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we just had it poorly named beforehand. The module wasn't really the module loader 🤷
feels like there are some QoL improvements you could pull out of this (like the loadScript refactor) that would make it easier to ship them and then easier to review this 🙈 |
That's fair. Didn't want to spend too much time here... But yeah I can split out the bundle changes from the functional changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runs locally
depends... it runs locally for me, so might be easier to just ship it 🙈 |
i suppose only risk here is someone is importing from |
I think thats fine, especially as it is npm only in that case so they would have the minor upgrade and we don't document that as an option anywhere |
Changes
.mts
as tsc doesn't like it so used a sub extension to indicate targetfull
fileChecklist