Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Type issue with RN #119

Merged
merged 7 commits into from
Oct 9, 2023
Merged

fix: Type issue with RN #119

merged 7 commits into from
Oct 9, 2023

Conversation

benjackwhite
Copy link
Collaborator

@benjackwhite benjackwhite commented Oct 9, 2023 •
edited
Loading

Problem

Might fix #117

Changes

Seems like we have some weird typing import issues that happened. Not sure why or how, so need to validate this and ideally add a test...

Release info Sub-libraries affected

Bump level

  • Major
  • Minor
  • Patch

Libraries affected

  • All of them
  • posthog-web
  • posthog-node
  • posthog-react-native

Changelog notes

  • Added support for X

@benjackwhite benjackwhite mentioned this pull request Oct 9, 2023
Closed
7 tasks
@benjackwhite benjackwhite marked this pull request as ready for review October 9, 2023 15:18
@benjackwhite benjackwhite merged commit 9ac7090 into master Oct 9, 2023
3 checks passed
@benjackwhite benjackwhite deleted the fix/type-issue branch October 9, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

@robbie-c robbie-c Awaiting requested review from robbie-c

@neilkakkar neilkakkar Awaiting requested review from neilkakkar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

react-native: PostHogCore types not imported
2 participants
@benjackwhite @marandaneto