-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added useFeatureFlagWithPayload for react native #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition! One small tweak requested as I feel its important we get the lifecycle right. If you don't have time, let me know and I can create a PR to go in that direction
@benjackwhite I think this is ready to go! |
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jonatthu can you split the PR into 2 PRs, one for the useFeatureFlagWithPayload
and the other one for the Sentry integration? it's pretty much a copy and paste.
The idea is that if something goes wrong, we can easily revert, it's also easier to read the history of changes.
Thanks for doing this.
Enabling feature flags with payload, this should be essential to have...
@marandaneto Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marandaneto Done
thanks, feel free to open a new PR with the Sentry bits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but let's wait @benjackwhite to double-check it since he requested changes.
@marandaneto Done, Can we merge it now? |
Enabling feature flags with payload, this should be essential to have...
Problem
Enables feature flags with payload for react native
Changes
It just exposes a new hook for this.
Release info Sub-libraries affected
Bump level
Libraries affected
Changelog notes