Added useFeatureFlagWithPayload for react native #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonatthu
changed the title
neilkakkar
reviewed
Sep 26, 2023
benjackwhite
requested changes
Sep 26, 2023
|
@benjackwhite I think this is ready to go! |
Jonatthu
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
marandaneto
requested changes
Sep 27, 2023
There was a problem hiding this comment.
@Jonatthu can you split the PR into 2 PRs, one for the useFeatureFlagWithPayload and the other one for the Sentry integration? it's pretty much a copy and paste.
The idea is that if something goes wrong, we can easily revert, it's also easier to read the history of changes.
Thanks for doing this.
Enabling feature flags with payload, this should be essential to have...
Jonatthu
changed the title
|
@marandaneto Done |
marandaneto
reviewed
Sep 28, 2023
There was a problem hiding this comment.
@marandaneto Done
thanks, feel free to open a new PR with the Sentry bits.
marandaneto
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
LGTM but let's wait @benjackwhite to double-check it since he requested changes.
benjackwhite
approved these changes
Oct 5, 2023
|
@marandaneto Done, Can we merge it now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling feature flags with payload, this should be essential to have...
Problem
Enables feature flags with payload for react native
Changes
It just exposes a new hook for this.
Release info Sub-libraries affected
Bump level
Libraries affected
Changelog notes