feat: allow a caller to override the generated session id #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilkakkar
reviewed
Aug 23, 2023
| @@ -677,7 +677,7 @@ export abstract class PostHogCore extends PostHogCoreStateless { | |||
| ...this.sessionProps, // Followed by session properties | |||
| ...(properties || {}), // Followed by user specified properties | |||
| ...this.getCommonEventProperties(), // Followed by FF props | |||
| $session_id: this.getSessionId(), | |||
| $session_id: properties?.['$session_id'] || this.getSessionId(), | |||
There was a problem hiding this comment.
flyby, this is not changing anything in posthog-node.
posthog-node uses the PostHogCoreStateless client (and not PostHogCore), and has separate tests for it in the posthog-node folder
There was a problem hiding this comment.
I'm actually not 100% sure how we could ignore a property or override it like so in posthog-node 🤔
There was a problem hiding this comment.
to test, go to cd examples/example-node and then yarn ts-node example.ts and change example.ts to do what you want to do
marandaneto
deleted the
feat/allow-caller-to-override-the-session-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
see private zendesk ticket: https://posthoghelp.zendesk.com/agent/tickets/5224
A posthog-node user was explicitly setting
$session_idon events and we were silently ignoring it.Changes
Allows a caller to override $session_id
Release info Sub-libraries affected
Bump level
Libraries affected
Changelog notes