fix: add UITextEffectsWindow type in screen ignore list #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
follow up for: #269
ticket: https://posthoghelp.zendesk.com/agent/tickets/21072
We missed
UITextEffectsWindow
which is another window presented when keyboard appears (for SwiftUI at least).I also listed all the UIViewController types in code so we know what we believe we are ignoring. If any $screen event ever pops up with on of those UIViewController types, then it means it was presented on another UIWindow type.
Note: We don't ignore any other system UIViewController / UIWindow (e.g UIActivityViewController) but:
💚 How did you test it?
Local sample project
📝 Checklist