Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add UITextEffectsWindow type in screen ignore list #279

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

ioannisj
Copy link
Contributor

💡 Motivation and Context

follow up for: #269
ticket: https://posthoghelp.zendesk.com/agent/tickets/21072

We missed UITextEffectsWindow which is another window presented when keyboard appears (for SwiftUI at least).

I also listed all the UIViewController types in code so we know what we believe we are ignoring. If any $screen event ever pops up with on of those UIViewController types, then it means it was presented on another UIWindow type.

Note: We don't ignore any other system UIViewController / UIWindow (e.g UIActivityViewController) but:

  1. I doubt these will ever prove problematic in terms of billing (a messaging app was flooded with keyboard screen events)
  2. They may be even useful for some customers

💚 How did you test it?

Local sample project

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@ioannisj ioannisj requested a review from a team December 23, 2024 12:35
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ioannisj ioannisj merged commit 87cc0e2 into main Dec 23, 2024
6 checks passed
@ioannisj ioannisj deleted the fix/keyboard-screen-events branch December 23, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants