Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix reset session when reset or close are called #107

Merged
merged 4 commits into from
Feb 18, 2024
Merged

fix reset session when reset or close are called #107

merged 4 commits into from
Feb 18, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Feb 16, 2024 •
edited
Loading

💡 Motivation and Context

Calling reset wasn't resetting the session.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto marked this pull request as ready for review February 16, 2024 13:07
@marandaneto marandaneto requested a review from a team February 16, 2024 13:07
daibhin
daibhin approved these changes Feb 16, 2024
View reviewed changes
Copy link

@daibhin daibhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appeciate a test 🙌

@marandaneto marandaneto merged commit 5a5451f into main Feb 18, 2024
11 checks passed
@marandaneto marandaneto deleted the fix/reset-session branch February 18, 2024 07:41
@marandaneto marandaneto mentioned this pull request Feb 19, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daibhin daibhin daibhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marandaneto @daibhin