fix

PostHog · Jan 10, 2024 · 4a206d3 · 4a206d3
1 parent 90bdcf4
commit 4a206d3
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 26 deletions.
diff --git a/PostHog/PostHogSDK.swift b/PostHog/PostHogSDK.swift
@@ -41,7 +41,6 @@ let maxRetryDelay = 30.0
     private static var apiKeys = Set<String>()
     private var capturedAppInstalled = false
     private var appFromBackground = false
-    private var ignoreFirstAppFromBackground = true
 
     @objc public static let shared: PostHogSDK = {
         let instance = PostHogSDK(PostHogConfig(apiKey: ""))
@@ -651,7 +650,7 @@ let maxRetryDelay = 30.0
                                       object: nil)
             defaultCenter.addObserver(self,
                                       selector: #selector(captureAppOpenedFromBackground),
-                                      name: UIApplication.willEnterForegroundNotification,
+                                      name: UIApplication.didBecomeActiveNotification,
                                       object: nil)
         #endif
     }
@@ -739,14 +738,6 @@ let maxRetryDelay = 30.0
     }
 
     @objc func captureAppOpenedFromBackground() {
-        // when the app is opened for the first time, the OS sends 2 notifications, didFinishLaunchingNotification
-        // and willEnterForegroundNotification, but we only want to log one "Application Opened" event.
-        // All the following app opened from background events should be logged normally.
-        if ignoreFirstAppFromBackground {
-            ignoreFirstAppFromBackground = false
-            return
-        }
-
         var props: [String: Any] = [:]
         props["from_background"] = appFromBackground
 
@@ -763,7 +754,6 @@ let maxRetryDelay = 30.0
         }
 
         captureAppInstalled()
-        captureAppOpened()
     }
 
     @objc func captureAppBackgrounded() {

diff --git a/PostHogTests/PostHogSDKTest.swift b/PostHogTests/PostHogSDKTest.swift
@@ -341,22 +341,9 @@ class PostHogSDKTest: QuickSpec {
             sut.close()
         }
 
-        it("ignore first AppOpenedFromBackground") {
-            let sut = self.getSut()
-
-            sut.captureAppOpenedFromBackground()
-
-            expect(server.batchRequests.count) == 0
-
-            sut.reset()
-            sut.close()
-        }
-
         it("capture AppOpenedFromBackground from_background should be false") {
             let sut = self.getSut()
 
-            // the first call is just to flip the ignoreFirstAppFromBackground flag
-            sut.captureAppOpenedFromBackground()
             sut.captureAppOpenedFromBackground()
 
             let events = getBatchedEvents(server)
@@ -374,8 +361,6 @@ class PostHogSDKTest: QuickSpec {
         it("capture AppOpenedFromBackground from_background should be true") {
             let sut = self.getSut(flushAt: 2)
 
-            // the first call is just to flip the ignoreFirstAppFromBackground flag
-            sut.captureAppOpenedFromBackground()
             sut.captureAppOpenedFromBackground()
             sut.captureAppOpenedFromBackground()