Fix rotation

PostHog · Feb 5, 2024 · 38d15b2 · 38d15b2
1 parent 89a371e
commit 38d15b2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/PostHog/PostHogSDK.swift b/PostHog/PostHogSDK.swift
@@ -261,12 +261,12 @@ private let sessionChangeThreshold: TimeInterval = 1800
         storage?.setString(forKey: .sessionId, contents: newValue)
     }
 
-    private func getSessionlastTimestamp() -> TimeInterval? {
-        storage?.getDouble(forKey: .sessionlastTimestamp)
+    private func getSessionLastTimestamp() -> TimeInterval? {
+        storage?.getDouble(forKey: .sessionLastTimestamp)
     }
 
-    private func setSessionlastTimestamp(_ newValue: TimeInterval) {
-        storage?.setDouble(forKey: .sessionlastTimestamp, contents: newValue)
+    private func setSessionLastTimestamp(_ newValue: TimeInterval) {
+        storage?.setDouble(forKey: .sessionLastTimestamp, contents: newValue)
     }
 
     // register is a reserved word in ObjC
@@ -382,8 +382,6 @@ private let sessionChangeThreshold: TimeInterval = 1800
         guard let queue = queue else {
             return
         }
-
-        rotateSessionIdIfRequired()
 
         queue.add(PostHogEvent(
             event: event,
@@ -606,8 +604,8 @@ private let sessionChangeThreshold: TimeInterval = 1800
     }
 
     private func rotateSessionIdIfRequired() {
-        let sessionId = storage?.getString(forKey: .sessionId)
-        let sessionLastTimestamp = storage?.getDouble(forKey: .sessionlastTimestamp)
+        let sessionId = getSessionId()
+        let sessionLastTimestamp = getSessionLastTimestamp()
 
         guard let _ = sessionId, let sessionLastTimestamp = sessionLastTimestamp else {
             rotateSession()
@@ -621,10 +619,10 @@ private let sessionChangeThreshold: TimeInterval = 1800
 
     private func rotateSession() {
         let sessionId = UUID()
-        let sessionlastTimestamp = Date()
+        let sessionLastTimestamp = Date()
 
         setSessionId(sessionId.uuidString)
-        setSessionlastTimestamp(sessionlastTimestamp.timeIntervalSince1970)
+        setSessionLastTimestamp(sessionLastTimestamp.timeIntervalSince1970)
     }
 
     @objc public func optIn() {

diff --git a/PostHog/PostHogStorage.swift b/PostHog/PostHogStorage.swift
@@ -31,7 +31,7 @@ class PostHogStorage {
         case registerProperties = "posthog.registerProperties"
         case optOut = "posthog.optOut"
         case sessionId = "posthog.sessionId"
-        case sessionlastTimestamp = "posthog.sessionlastTimestamp"
+        case sessionLastTimestamp = "posthog.sessionLastTimestamp"
     }
 
     private let config: PostHogConfig