Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue with premature image disposal causing black replay #139

Merged

Conversation

thisames
Copy link
Contributor

  • Delayed image disposal until after masking to ensure validity during processing.
  • Ensured proper memory management by disposing of images only after usage.
  • Added getImageBytes

I removed ui.Image image from ImageInfo cause we not used it in anywhere and we always dispose it too.

💡 Motivation and Context

#138

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

Sorry, something went wrong.

…s in dashboard

- Delayed image disposal until after masking to ensure validity during processing.
- Ensured proper memory management by disposing of images only after usage.
- Added getImageBytes
@Fernandomr88
Copy link

any ETA on this?

@marandaneto
Copy link
Member

any ETA on this?

Sorry for the delay, Just back from the holidays and looking into it right now.

Copy link
Member

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thisames

@marandaneto
Copy link
Member

I pushed a few fixes

fix
@marandaneto marandaneto merged commit 30dd729 into PostHog:main Jan 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants