Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recording: fix registering the ViewTreeObserver when its not attached yet #144

Merged
merged 2 commits into from
Jun 17, 2024
Merged

recording: fix registering the ViewTreeObserver when its not attached yet #144

merged 2 commits into from
Jun 17, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Jun 17, 2024 •
edited
Loading

💡 Motivation and Context

sometimes the SDK inits so early that the view isn't attached yet.

💚 How did you test it?

running and debugging before view is attached

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto marked this pull request as ready for review June 17, 2024 14:40
@marandaneto marandaneto requested a review from a team June 17, 2024 14:41
pauldambra
pauldambra approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very low context stamp 🙈 😅

@marandaneto marandaneto merged commit 25d0e08 into main Jun 17, 2024
10 checks passed
@marandaneto marandaneto deleted the fix/ViewTreeObserver-attached branch June 17, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marandaneto @pauldambra