This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
Add Prometheus metrics exporting #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellie
force-pushed
the
ellie/metrics
branch
from
0b95621
to
726e535
Compare
xvello
approved these changes
Sep 14, 2023
tests/django_compat.rs
Outdated
| @@ -90,7 +90,7 @@ async fn it_matches_django_capture_behaviour() -> anyhow::Result<()> { | |||
|
|
|||
| let sink = MemorySink::default(); | |||
| let timesource = FixedTime { time: case.now }; | |||
| let app = router(timesource, sink.clone()); | |||
| let app = router(timesource, sink.clone(), false); | |||
|
|
|||
| let client = TestClient::new(app); | |||
| let mut req = client.post(&case.path).body(raw_body); | |||
There was a problem hiding this comment.
nit: tests will break due to /e not being exposed anymore, I'll patch it myself to rewrite the path
ellie
force-pushed
the
ellie/metrics
branch
from
b4e63c4
to
d796633
Compare
ellie
force-pushed
the
ellie/metrics
branch
from
d796633
to
dec9fd8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for us to know what is going on