Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add float timestamp support in python #1794

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

ljeub-pometry
Copy link
Collaborator

What changes were proposed in this pull request?

Add conversion from float for python timestamp input

Why are the changes needed?

Supports the format returned by the timestamp method on python datetime objects

Does this PR introduce any user-facing change? If yes is this documented?

How was this patch tested?

Added test to make sure this works

Issues

fixes #1754

Are there any further changes required?

Copy link
Collaborator

@miratepuffin miratepuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miratepuffin miratepuffin merged commit e0c76c1 into master Oct 1, 2024
19 checks passed
@miratepuffin miratepuffin deleted the feature/PythonFloatTimestamps branch October 1, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for floats as timestamps
2 participants