Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In_component out_component #1790

Merged
merged 14 commits into from
Oct 2, 2024
Merged

In_component out_component #1790

merged 14 commits into from
Oct 2, 2024

Conversation

miratepuffin
Copy link
Collaborator

@miratepuffin miratepuffin commented Sep 24, 2024

What changes were proposed in this pull request?

Added the ability to query the in_component and out_component of a node.

Why are the changes needed?

  1. This is currently a pain to do in graphql
  2. Often we only want this for a singular/small number of nodes, so not worth doing for all nodes

Does this PR introduce any user-facing change? If yes is this documented?

yes and yes

How was this patch tested?

new tests for rust, python and graphql

Issues

Fixes #1769

Are there any further changes required?

No

Copy link
Collaborator

@ljeub-pometry ljeub-pometry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor, very easy optimisations and this should be good to go

Copy link
Collaborator

@ljeub-pometry ljeub-pometry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one set of imports could be cleaned up

@miratepuffin miratepuffin merged commit 318dc9a into master Oct 2, 2024
19 checks passed
@miratepuffin miratepuffin deleted the feature/latest_and_active branch October 2, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add in_component/out_component on nodes
2 participants