More edge property filters #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miratepuffin
approved these changes
Sep 19, 2024
| ) -> Result<Option<usize>, GraphError> { | ||
| match self.get_id(prop) { | ||
| Some(id) => { | ||
| let existing_dtype = self.get_dtype(id).unwrap(); |
There was a problem hiding this comment.
I know this cannot fail, but worth turning the unwrap into a '?'
There was a problem hiding this comment.
Can turn it into an expect, if this is ever not true, we want shit to blow up!
ljeub-pometry
force-pushed
the
feature/MorePropertyFilters
branch
from
352aabd to
3e1d621
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 3dd5eeb | Previous: 5f0ae40 | Ratio |
|---|---|---|---|
lotr_graph_subgraph_10pc/active edge |
462 ns/iter (± 37) |
225 ns/iter (± 8) |
2.05 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ne,ge,leWhy are the changes needed?
we need to filter properties
Does this PR introduce any user-facing change? If yes is this documented?
yes, more methods with python doc strings
How was this patch tested?
needs more tests
Are there any further changes required?
more tests