Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL vector updates #1778

Merged
merged 52 commits into from
Oct 1, 2024
Merged

GraphQL vector updates #1778

merged 52 commits into from
Oct 1, 2024

Conversation

ricopinazo
Copy link
Contributor

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change? If yes is this documented?

How was this patch tested?

Issues

If this resolves any issues, please link to them here, the format is a KEYWORD followed by @_
KEYWORDS available are close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved.
Please delete this text before creating your PR

Are there any further changes required?

# Conflicts:
#	raphtory-graphql/Cargo.toml
#	raphtory-graphql/src/data.rs
#	raphtory-graphql/src/lib.rs
#	raphtory-graphql/src/model/graph/graph.rs
#	raphtory-graphql/src/model/graph/graphs.rs
#	raphtory-graphql/src/model/graph/mutable_graph.rs
#	raphtory-graphql/src/model/mod.rs
#	raphtory-graphql/src/server.rs
#	raphtory/src/serialise/serialise.rs
#	raphtory/src/vectors/template.rs
#	raphtory/src/vectors/vector_selection.rs
#	raphtory/src/vectors/vectorisable.rs
@ricopinazo ricopinazo marked this pull request as ready for review September 23, 2024 12:49
# Conflicts:
#	python/tests/graphql/edit_graph/test_deprecated_save.py
#	raphtory-graphql/src/data.rs
#	raphtory-graphql/src/lib.rs
#	raphtory-graphql/src/model/algorithms/global_search.rs
#	raphtory-graphql/src/model/algorithms/similarity_search.rs
#	raphtory-graphql/src/model/mod.rs
#	raphtory-graphql/src/model/plugins/query_plugin.rs
#	raphtory-graphql/src/model/plugins/vector_algorithm_plugin.rs
#	raphtory-graphql/src/python/server/server.rs
#	raphtory-graphql/src/server.rs

println!("Graph loaded = {}", folder.get_original_path_str());
Ok(Self {
graph: IndexedGraph::from_graph(&graph)?,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to test how long the indexing is taking on big graphs

Copy link
Collaborator

@miratepuffin miratepuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small changes and we are good to go!

Copy link
Collaborator

@miratepuffin miratepuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miratepuffin miratepuffin merged commit 03c6a2e into master Oct 1, 2024
16 checks passed
@miratepuffin miratepuffin deleted the feature/graphql-vector-updates branch October 1, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants