Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix latest_time for exploded edge on PersistentGraph for edges that are deleted at the same time as created #1752

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

ljeub-pometry
Copy link
Collaborator

What changes were proposed in this pull request?

fixes:

G1 = PersistentGraph()

G1.add_edge(1, 1, 2, properties={"message":"hi"})
G1.delete_edge(1, 1, 2)

print(f"G1's edges are {G1.edges.explode()}")

which was returning

G1's edges are Edges(Edge(source=1, target=2, earliest_time=1, latest_time=9223372036854775807, properties={message: hi}))

but the latest_time should have been 1.

How was this patch tested?

Added test for this case

Copy link
Collaborator

@narnolddd narnolddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Looks good :)

@miratepuffin miratepuffin merged commit b1105e0 into master Sep 6, 2024
19 checks passed
@miratepuffin miratepuffin deleted the bug/PersistentGraphExplodedLatestTime branch September 6, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants