Graphql logging #1746
Merged
Graphql logging #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljeub-pometry
approved these changes
Sep 9, 2024
|
|
||
| async fn unique_layers(&self) -> Vec<String> { | ||
| self.graph.unique_layers().map_into().collect() | ||
| } | ||
| #[instrument(skip(self))] | ||
|
|
There was a problem hiding this comment.
weird blank lines in this file (some places lost the blank line between functions and other have a blank line after the attribute like here)
# Conflicts: # Cargo.lock
| from raphtory import Graph | ||
| from raphtory.graphql import GraphServer, RaphtoryClient | ||
|
|
||
| # TODO this doesn't work currently due to how we terminate with Tracing |
There was a problem hiding this comment.
Have we fixed this?
There was a problem hiding this comment.
Yes, we can turn this test back on.
| Some(tracer_provider) | ||
| } | ||
| Err(e) => { | ||
| error!("{}", e.to_string()); |
There was a problem hiding this comment.
do we just move on if we were told to enable tracing but we couldn't?
|
This was a lot of work, but I can't help but thinking 90% of these |
added 3 commits
September 18, 2024 16:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change? If yes is this documented?
No
How was this patch tested?
Current test suite
Issues
Fixes #1697
Are there any further changes required?