-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write-locked graph storage implementation for faster bulk loaders #1741
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2
.
Benchmark suite | Current: 27bfa2b | Previous: fcf885a | Ratio |
---|---|---|---|
lotr_graph/iterate nodes |
13073 ns/iter (± 43 ) |
4433 ns/iter (± 111 ) |
2.95 |
lotr_graph_window_100/iterate nodes |
13297 ns/iter (± 48 ) |
4446 ns/iter (± 133 ) |
2.99 |
lotr_graph_window_10/iterate nodes |
15005 ns/iter (± 71 ) |
5861 ns/iter (± 130 ) |
2.56 |
lotr_graph_subgraph_10pc/num_nodes |
31351 ns/iter (± 622 ) |
15384 ns/iter (± 1182 ) |
2.04 |
lotr_graph_subgraph_10pc/iterate nodes |
11483 ns/iter (± 63 ) |
3163 ns/iter (± 85 ) |
3.63 |
lotr_graph_subgraph_10pc_windowed/iterate nodes |
11644 ns/iter (± 70 ) |
3375 ns/iter (± 41 ) |
3.45 |
lotr_graph_subgraph_10pc_windowed/iterate edges |
17294 ns/iter (± 67 ) |
8390 ns/iter (± 178 ) |
2.06 |
lotr_graph_window_50_layered/iterate nodes |
16398 ns/iter (± 9 ) |
7938 ns/iter (± 82 ) |
2.07 |
lotr_graph_persistent_window_50_layered/num_nodes |
37338 ns/iter (± 3689 ) |
16261 ns/iter (± 244 ) |
2.30 |
This comment was automatically generated by workflow using github-action-benchmark.
e66e98f
to
00bd059
Compare
b0ad98e
to
deef6f4
Compare
…properties if there are none
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What changes were proposed in this pull request?
Adds write-locked views for the underlying graph storage which should enable faster bulk loaders
Why are the changes needed?
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Issues
If this resolves any issues, please link to them here, the format is a KEYWORD followed by @_
KEYWORDS available are
close
,closes
,closed
,fix
,fixes
,fixed
,resolve
,resolves
,resolved
.Please delete this text before creating your PR
Are there any further changes required?