-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL mutation apis #1719
GraphQL mutation apis #1719
Conversation
efd304e
to
8056113
Compare
Random stuff I have found
|
…pdates are not being indexed)
that is just how GraphQL works |
…ry/Raphtory into feature/GraphQl-mutations
…Server, updated stubs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the nicer error message check is not atomic. There is still a small chance of getting the IO error instead.
return Err(GraphError::GraphNameAlreadyExists(path.to_path_buf()).into()); | ||
} | ||
create_dirs_if_not_present(&full_path)?; | ||
let mut cache = File::create_new(full_path)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can still fail with the mysterious IO error here if someone manages to create the file between the previous check and this one. Probably better to only use this to check and map the error for a better message.
What changes were proposed in this pull request?
Add support for creating and mutating graphs using GraphQL
Graph Functions
Node functions
Edge functions
Why are the changes needed?
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Issues
If this resolves any issues, please link to them here, the format is a KEYWORD followed by @_
KEYWORDS available are
close
,closes
,closed
,fix
,fixes
,fixed
,resolve
,resolves
,resolved
.Please delete this text before creating your PR
Are there any further changes required?