Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cached graph #1718

Merged
merged 30 commits into from
Aug 21, 2024
Merged

Feature/cached graph #1718

merged 30 commits into from
Aug 21, 2024

Conversation

ljeub-pometry
Copy link
Collaborator

@ljeub-pometry ljeub-pometry commented Aug 19, 2024

What changes were proposed in this pull request?

Adds support for caching graph updates to file using the new incremental file format.

Why are the changes needed?

Avoid rewriting the entire graph on updates with the new graph cache in the GraphQL server

Does this PR introduce any user-facing change? If yes is this documented?

Adds new public traits (some doc strings but needs fleshing out)

How was this patch tested?

Existing tests and new test for incremental caching

Issues

resolves #1704

Are there any further changes required?

Still TODO:

  • Add Python methods
  • Add tests
  • Use it in the GraphQL server

@ljeub-pometry ljeub-pometry marked this pull request as ready for review August 20, 2024 11:47
Copy link
Collaborator

@miratepuffin miratepuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miratepuffin miratepuffin merged commit c655ee6 into master Aug 21, 2024
19 checks passed
@miratepuffin miratepuffin deleted the feature/CachedGraph branch August 21, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make protobuf incremental
2 participants