Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/incremental protobuf #1706

Merged
merged 23 commits into from
Aug 8, 2024
Merged

Conversation

ljeub-pometry
Copy link
Collaborator

@ljeub-pometry ljeub-pometry commented Aug 6, 2024

What changes were proposed in this pull request?

  • Rework of the proto format to allow for appending new updates to an existing file
  • Minor improvements to the internal additions apis for edges and node types to simplify the deserialisation implementation
  • Adds check for temporal graph properties so they cannot change type
  • Fixes a datetime parsing issues in python where naive DateTime was treated as local rather than UTC

Why are the changes needed?

Incremental creation of serialised graphs (especially for the GraphQL server)

Does this PR introduce any user-facing change? If yes is this documented?

No

How was this patch tested?

existing tests and new test to show the incremental serialisation

Issues

This is the first part of #1704

Are there any further changes required?

Actual interface for incremental writing

@ljeub-pometry ljeub-pometry force-pushed the feature/IncrementalProtobuf branch 2 times, most recently from 3443ab3 to 5b85ff0 Compare August 7, 2024 12:27
@ljeub-pometry ljeub-pometry force-pushed the feature/IncrementalProtobuf branch 2 times, most recently from 106239b to 3832f01 Compare August 7, 2024 12:39
@ljeub-pometry ljeub-pometry force-pushed the feature/IncrementalProtobuf branch from 3832f01 to 7a10261 Compare August 7, 2024 12:40
@ljeub-pometry ljeub-pometry force-pushed the feature/IncrementalProtobuf branch from 8152b39 to e981797 Compare August 7, 2024 14:47
@ljeub-pometry ljeub-pometry force-pushed the feature/IncrementalProtobuf branch from e981797 to 7ac0bac Compare August 7, 2024 14:55
@ljeub-pometry ljeub-pometry merged commit ac8fa2d into master Aug 8, 2024
19 checks passed
@ljeub-pometry ljeub-pometry deleted the feature/IncrementalProtobuf branch August 8, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants