Pre multi graph #1695
Merged
Pre multi graph #1695
+3,340
−4,987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the OS Raphtory support GID
fabianmurariu
force-pushed
the
pre_multi_graph
branch
from
d67043a to
31a9336
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: aa0722b | Previous: b0fe8cb | Ratio |
|---|---|---|---|
lotr_graph/has_node_existing |
17 ns/iter (± 1) |
6 ns/iter (± 0) |
2.83 |
This comment was automatically generated by workflow using github-action-benchmark.
miratepuffin
requested changes
Jul 24, 2024
ljeub-pometry
requested changes
Jul 25, 2024
| "# checking edge 1,2 exists and 2,1 doesn't as Raphtory is directed\n", | ||
| "print(g.has_edge(1, 2), g.has_edge(2, 1))\n", | ||
| "print(g.has_edge(\"1\", \"2\"), g.has_edge(\"2\", \"1\"))\n", | ||
| "# Check the total number of edges and nodes\n", |
There was a problem hiding this comment.
Instead of changing all the numbers to strings, we probably should make the example with string ids use a new graph instead so this still explains both scenarios
This was referenced Jul 26, 2024
miratepuffin
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move most of the graph logic into GraphStorage
Add
iterin Nodes that returns NodeView with references and avoid cloneshand node ids that are strings better
Why are the changes needed?
Simplify the implementation of a multi graph
Does this PR introduce any user-facing change? If yes is this documented?
No
How was this patch tested?
Issues
#1686
Are there any further changes required?