Stable serialise #1683
Merged
Stable serialise #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianmurariu
force-pushed
the
stable_serialise
branch
from
e211d72 to
be1ae08
Compare
ljeub-pometry
requested changes
Jul 9, 2024
There was a problem hiding this comment.
Some quick changes:
- make the decode methods into actual constructors to avoid panics with calling them on non-empty graphs
- use the existing functionality for the string interning rather than reinventing it
- make sure the bincode methods get the versioning and add them to the
PersistentGraphas well (also make the corresponding python methods that already exist call this new implementation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add support to serialise the graph into protobuf format
Why are the changes needed?
allow us to encode/decode a graph even if the internal structure changes
Does this PR introduce any user-facing change? If yes is this documented?
new functions
How was this patch tested?
unit
Issues
closes #1679
Are there any further changes required?