Improve python extensibility #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljeub-pometry
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR we broke the raphtory python module function down into several helper functions which return the submodules (algorithms, graphql, etc) making it much easier to build custom versions of the raphtory python module.
Why are the changes needed?
The python module was set up in a way which made it difficult to extend for users who wish to build custom raphtory distributions with private algorithms etc.
Does this PR introduce any user-facing change? If yes is this documented?
Not for the average user - documentation on custom distros is on way.
How was this patch tested?
Tested via the standard unit tests, via the example extended raphtory library and privately.
Are there any further changes required?
There are several further project rejigs planned, but nothing more to do here.