-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/cached graphs #1656
Features/cached graphs #1656
Conversation
…ts, fix tests, impl save_to_path mat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many random notes - as we discussed I think we need to rethink the different pathways to upload a graph tomorrow and cut some of the confusion out of these functions.
After discussion, we should tidy the APIs to provide the following:
|
Implemented this leaving the |
* impl gqlgraphs * properties, unique layers to gqlgraphs * impl default configs, impl config load precedence, add tests * impl auth configs * wait for server to come online when started, also expose an api on client to see if server is already online, add tests * add client tests * fix tests * add load graphs tests * rid duplicate tests * wait internalised * rid silly auth config defaults
if we absolutely must println, we should use tracing https://docs.rs/tracing/latest/tracing/attr.instrument.html otherwise we should remove them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Disable load graph from path for both GraphQL and python apis (keep internal function as we may want to add back).
- Change the return type of python mv,copy,delete to just Result<()>
- Decode the graph within python receive (you have the code already in a test)
- Nuke the tracing as we are going to do our own one
- Disable auth for user APIs until we have audited
pub fn load_graph_from_path( | ||
work_dir: &Path, | ||
path_on_server: &Path, | ||
namespace: &Option<String>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change this to an Option which would also allow renaming of the graph on copy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final bits to check through before merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The final review!
What changes were proposed in this pull request?
#1649
Why are the changes needed?
Same as above
Does this PR introduce any user-facing change? If yes is this documented?
No
How was this patch tested?
Uni, integration and manual tests
Issues
If this resolves any issues, please link to them here, the format is a KEYWORD followed by @_
KEYWORDS available are
close
,closes
,closed
,fix
,fixes
,fixed
,resolve
,resolves
,resolved
.Please delete this text before creating your PR
Are there any further changes required?
No