Add largest connected component method #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # raphtory/src/python/graph/graph.rs
miratepuffin
requested changes
Apr 11, 2024
miratepuffin
approved these changes
Apr 14, 2024
fabianmurariu
pushed a commit
that referenced
this pull request
May 21, 2024
* Add largest connected component method * Expose lcc to python * Expose lcc to python * optimise the function * run cargo +nightly fmt * Missed a bracket on the merge * run cargo +nightly fmt --------- Co-authored-by: Ben Steer <b.a.steer@qmul.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pull request introduces a method that extracts the largest connected component from a graph. The method, utilises the weakly connected components algorithm to identify and return the largest connected component as a new sub-graph.
Why are the changes needed?
Resolves an issue.
Does this PR introduce any user-facing change? If yes is this documented?
Yes, it adds a new algorithm method that is exposed through the graph.rs API. While this change is currently not documented, I am prepared to provide documentation upon request.
How was this patch tested?
Unit tests, in Python and Rust: tested against an empty graph, single connected component, multiple connected components, and same size connected components.
Issues
resolves#1214Are there any further changes required?
Return a neater warning message when there are two or more largest connected components. Can do that upon request.