Allow props to be returned as JSON & Upgrade rust to 1.75 #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haaroon
changed the title
|
the test pass locally what are u doin github |
miratepuffin
approved these changes
Feb 12, 2024
fabianmurariu
pushed a commit
that referenced
this pull request
May 21, 2024
* expose props to json * add multiple test to cover map+list+prop types * UPGRADE RUST to 1.75 * this frankenstien almost works, its still a string * fixed properties with new ScalarType * commit cleaner names * convert props to use actual gql types and vice versa * delete crap off gh workflow runner to get more hdd space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
to_jsonfunction in both rust and graphqlWhy are the changes needed?
For GQLProps via GraphQL
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Multiple tests
Issues
Are there any further changes required?