-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Louvain algorithm #1425
Merged
Merged
Louvain algorithm #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miratepuffin
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove the print statement, but I can quickly do this
Comment on lines
59
to
62
println!( | ||
"Finished outer iteration, num_coms={}, modularity={}", | ||
partition.num_coms(), | ||
modularity_state.value() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove this
fabianmurariu
pushed a commit
that referenced
this pull request
May 21, 2024
* implement undirected modularity function * actual louvain algorithm * test files * fix some issues * add test on LFR benchmark * louvain algorithm that seems to work * make the network undirected * better handling of tol in modularity * clean up debug code * add python wrapper * removed println --------- Co-authored-by: miratepuffin <b.a.steer@qmul.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implements the Louvain algorithm and undirected modularity function
Why are the changes needed?
More community detection methods
Does this PR introduce any user-facing change? If yes is this documented?
documentation is lacking and no python interface yet
How was this patch tested?
Some tests added to check it works
Issues
If this resolves any issues, please link to them here, the format is a KEYWORD followed by @_
KEYWORDS available are
close
,closes
,closed
,fix
,fixes
,fixed
,resolve
,resolves
,resolved
.Please delete this text before creating your PR
Are there any further changes required?
Add python interface and more modularity variants