Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Louvain algorithm #1425

Merged
merged 12 commits into from
Dec 21, 2023
Merged

Louvain algorithm #1425

merged 12 commits into from
Dec 21, 2023

Conversation

ljeub-pometry
Copy link
Collaborator

What changes were proposed in this pull request?

Implements the Louvain algorithm and undirected modularity function

Why are the changes needed?

More community detection methods

Does this PR introduce any user-facing change? If yes is this documented?

documentation is lacking and no python interface yet

How was this patch tested?

Some tests added to check it works

Issues

If this resolves any issues, please link to them here, the format is a KEYWORD followed by @_
KEYWORDS available are close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved.
Please delete this text before creating your PR

Are there any further changes required?

Add python interface and more modularity variants

Copy link
Collaborator

@miratepuffin miratepuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the print statement, but I can quickly do this

Comment on lines 59 to 62
println!(
"Finished outer iteration, num_coms={}, modularity={}",
partition.num_coms(),
modularity_state.value()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove this

@miratepuffin miratepuffin merged commit 4a88a15 into master Dec 21, 2023
10 checks passed
@miratepuffin miratepuffin deleted the feature/algo-louvain-mk2 branch December 21, 2023 17:31
fabianmurariu pushed a commit that referenced this pull request May 21, 2024
* implement undirected modularity function

* actual louvain algorithm

* test files

* fix some issues

* add test on LFR benchmark

* louvain algorithm that seems to work

* make the network undirected

* better handling of tol in modularity

* clean up debug code

* add python wrapper

* removed println

---------

Co-authored-by: miratepuffin <b.a.steer@qmul.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants