Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/more caching #1353

Merged
merged 20 commits into from
Oct 25, 2023
Merged

Feature/more caching #1353

merged 20 commits into from
Oct 25, 2023

Conversation

Haaroon
Copy link
Contributor

@Haaroon Haaroon commented Oct 25, 2023

What changes were proposed in this pull request?

Increase usage of caching in workflow runs causes a huge reduction in test times.

GH workflow testing times, old vs new

  • Rust (Mac) - 6m59s -> 9m36s
  • Rust (Ubuntu) - 13m41s -> 9m11s
  • Rust (Windows) - 17m14s -> 14m18s
  • Rust (building docs) - 15m28s -> 4m29s
  • Python (3.8 Mac) - 10m31s -> 19m47s (?)
  • Python (3.8 Ubuntu) - 11m19s -> 7m22s
  • Python (3.8 Windows) - 13m4s -> 22m40s (?)
  • Code coverage - 17m45s -> 25m27s (cache just saved)

Why are the changes needed?

Does this PR introduce any user-facing change? If yes is this documented?

How was this patch tested?

Issues

If this resolves any issues, please link to them here, the format is a KEYWORD followed by @_
KEYWORDS available are close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved.
Please delete this text before creating your PR

Are there any further changes required?

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0757c79) 58.24% compared to head (ec9ee70) 58.25%.

❗ Current head ec9ee70 differs from pull request most recent head d069782. Consider uploading reports for the commit d069782 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1353   +/-   ##
=======================================
  Coverage   58.24%   58.25%           
=======================================
  Files         190      190           
  Lines       20691    20691           
=======================================
+ Hits        12052    12053    +1     
+ Misses       8639     8638    -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Haaroon Haaroon merged commit f8445ae into master Oct 25, 2023
@Haaroon Haaroon deleted the feature/more-caching branch October 25, 2023 12:55
fabianmurariu pushed a commit that referenced this pull request May 21, 2024
* cache

* dont install from cargo as its too slow

* fix urls

* fix urls

* fix urls

* fix urls

* fix urls

* add sccache to code cov

* better sccache config in rust

* change code cov path for sccache

* change code cov path for sccache

* change code cov path for sccache

* change windows install

* fix bad ubuntu path

* add caching to python tests

* setup and show stats for cache server

* improvements to sscache

* add cache to doc tests

* change cache keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant