Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dijkstra Algorithm with Src, Dst and Weight #1321

Merged
merged 13 commits into from
Oct 6, 2023
Merged

Conversation

Haaroon
Copy link
Contributor

@Haaroon Haaroon commented Oct 4, 2023

What changes were proposed in this pull request?

  • Added Single Source Multiple Targets Dijsktra algorithm (weight) to rust and python
  • Both python and rust tests
  • Complete documentation

Why are the changes needed?

new algo

Does this PR introduce any user-facing change? If yes is this documented?

yes

How was this patch tested?

tests

Issues

resolves #1297

Are there any further changes required?

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (037daeb) 57.42% compared to head (543cf75) 57.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1321      +/-   ##
==========================================
+ Coverage   57.42%   57.61%   +0.19%     
==========================================
  Files         185      186       +1     
  Lines       19837    20014     +177     
==========================================
+ Hits        11391    11531     +140     
- Misses       8446     8483      +37     
Files Coverage Δ
python/src/lib.rs 4.76% <ø> (ø)
raphtory/src/python/packages/algorithms.rs 0.00% <0.00%> (ø)
raphtory/src/algorithms/pathing/dijkstra.rs 76.04% <76.04%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Haaroon Haaroon marked this pull request as ready for review October 5, 2023 13:48
@miratepuffin miratepuffin merged commit 3040db8 into master Oct 6, 2023
@miratepuffin miratepuffin deleted the feature/algo-dji-sp branch October 6, 2023 12:20
fabianmurariu pushed a commit that referenced this pull request May 21, 2024
* add sssp to docs

* djistraks algorithm

* dijkstra src dst tests

* dijkstra single source multiple targets algorithm

* documentation in rust

* changed to use multi path output only, added to python

* convert types to f64

* completed python tests

* fixed broken docs

* fixed issue with multiple weight types

* tidy up

* change base to use a result instead, add result and more error checks to python
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Djikstras shortest_path algorithm
2 participants