Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive #1271

Merged
merged 14 commits into from
Sep 22, 2023
Merged

Archive #1271

merged 14 commits into from
Sep 22, 2023

Conversation

shivamka1
Copy link
Collaborator

What changes were proposed in this pull request?

Gql api to archive/unarchive graph

Why are the changes needed?

Same as above

Does this PR introduce any user-facing change? If yes is this documented?

Yes

How was this patch tested?

Tests

Issues

If this resolves any issues, please link to them here, the format is a KEYWORD followed by @_
KEYWORDS available are close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved.
Please delete this text before creating your PR

Are there any further changes required?

No

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.24% ⚠️

Comparison is base (8096021) 57.99% compared to head (ef2f1a5) 57.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1271      +/-   ##
==========================================
- Coverage   57.99%   57.76%   -0.24%     
==========================================
  Files         173      173              
  Lines       18776    18854      +78     
==========================================
+ Hits        10890    10891       +1     
- Misses       7886     7963      +77     
Files Changed Coverage Δ
raphtory-graphql/src/model/mod.rs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@miratepuffin miratepuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, but can we change out the expects and it would cause the whole server to crash?

@miratepuffin miratepuffin merged commit 35fa556 into master Sep 22, 2023
@miratepuffin miratepuffin deleted the archive branch September 22, 2023 14:03
fabianmurariu pushed a commit that referenced this pull request May 21, 2024
* init archive graphs

* fix subgraph

* fix fmt

* upsert creation time for new graph as well as saved as graphs

* cargo fmt

* update lastUpdated time upon save

* rename graph

* fix issue with uiProps getting overwritten with last uiProps

* rid expectations

* fmt

* fix merge issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants