Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mixins to style with different invalid colors #435

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gerjanvangeest
Copy link

I wanted to use the paper-input but not style the label, underline and add-on in the same color when invalid. In the current situation all three elements where all styled by the variable:
--paper-input-container-invalid-color

With these three new mixins the label, underline and add-on can be styled individually.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@gerjanvangeest
Copy link
Author

gerjanvangeest commented Sep 6, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Sep 7, 2016
@notwaldorf
Copy link
Contributor

This is pretty against the material design spec, and it would produce a pretty mismatched input, so I'm not sure how I feel about this :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants