Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update promisify-node to 0.5.0 #434

Closed
wants to merge 2 commits into from
Closed

Update promisify-node to 0.5.0 #434

wants to merge 2 commits into from

Conversation

paladox
Copy link
Contributor

@paladox paladox commented Jun 5, 2018

@paladox paladox mentioned this pull request Jun 5, 2018
Closed
1 task
@jsilvermist
Copy link
Contributor

This needs to regen the lock file too.

@paladox
Copy link
Contributor Author

paladox commented Jun 5, 2018

done.

TimvdLippe
TimvdLippe suggested changes Jun 8, 2018
View reviewed changes
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome if this fixes all of our Node 10 issues. Could you add Node 10 to the CI build matrix to verify this issue is fixed?

@paladox paladox mentioned this pull request Jun 9, 2018
Closed
@paladox
Copy link
Contributor Author

paladox commented Jun 9, 2018

I've moved this to #496 to fix merge conflicts.

@paladox paladox closed this Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimvdLippe TimvdLippe TimvdLippe requested changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paladox @jsilvermist @TimvdLippe @googlebot