Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Replace pysha3 with compatible libs #34

Merged
merged 5 commits into from
Jul 18, 2024
Merged

Fix: Replace pysha3 with compatible libs #34

merged 5 commits into from
Jul 18, 2024

Conversation

JonathanAmenechi
Copy link
Contributor

@JonathanAmenechi JonathanAmenechi commented Jul 18, 2024 •
edited
Loading

Overview

  • Replace the web3 lib with eth-utils and eth-account, due to dependency lib pysha3's incompatibility with python 3.10 and above
  • Replace eip712_structs library with forked version

Description

Testing instructions

Types of changes

  • Refactor/enhancement
  • Bug fix/behavior correction
  • New feature
  • Breaking change
  • Other, additional

Notes

Status

  • Prefix PR title with [WIP] if necessary (changes not yet made).
  • Add tests to cover changes as needed.
  • Update documentation/changelog as needed.
  • Verify all tests run correctly in CI and pass.
  • Ready for review/merge.

@JonathanAmenechi JonathanAmenechi changed the title Fix: Upgrade to 6.20.0 web3 Fix: Replace web3 with eth-utils and eth-account Jul 18, 2024
@JonathanAmenechi JonathanAmenechi changed the title Fix: Replace web3 with eth-utils and eth-account [WIP] Fix: Replace web3 with eth-utils and eth-account Jul 18, 2024
@JonathanAmenechi JonathanAmenechi changed the title [WIP] Fix: Replace web3 with eth-utils and eth-account [WIP] Fix: Replace pysha3 with compatible libs Jul 18, 2024
@JonathanAmenechi JonathanAmenechi changed the title [WIP] Fix: Replace pysha3 with compatible libs Fix: Replace pysha3 with compatible libs Jul 18, 2024
@JonathanAmenechi JonathanAmenechi merged commit 113e913 into main Jul 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poly-rodr poly-rodr poly-rodr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonathanAmenechi @poly-rodr