Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: rm unused methods #31

Merged
merged 1 commit into from
Jan 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions py_order_utils/config.py
Original file line number Diff line number Diff line change
@@ -1,16 +1,12 @@
class ContractConfig:
def __init__(self, exchange, executor, collateral, conditional):
def __init__(self, exchange, collateral, conditional):
self.exchange = exchange
self.executor = executor
self.collateral = collateral
self.conditional = conditional

def get_exchange(self):
return self.exchange

def get_executor(self):
return self.executor

def get_collateral(self):
return self.collateral

Expand All @@ -25,13 +21,11 @@ def get_contract_config(chainID: int) -> ContractConfig:
CONFIG = {
137: ContractConfig(
exchange="0x4bFb41d5B3570DeFd03C39a9A4D8dE6Bd8B8982E",
executor="0xb2a29463Df393a4CAef36541544715e6B48b80B7",
collateral="0x2791Bca1f2de4661ED88A30C99A7a9449Aa84174",
conditional="0x4D97DCd97eC945f40cF65F87097ACe5EA0476045",
),
80001: ContractConfig(
exchange="0x4bFb41d5B3570DeFd03C39a9A4D8dE6Bd8B8982E",
executor="0xb2a29463Df393a4CAef36541544715e6B48b80B7",
collateral="0x2E8DCfE708D44ae2e406a1c02DFE2Fa13012f961",
conditional="0x7D8610E9567d2a6C9FBf66a5A13E9Ba8bb120d43",
),
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

setuptools.setup(
name="py_order_utils",
version="0.1.2",
version="0.1.3",
author="Polymarket Engineering",
author_email="engineering@polymarket.com",
maintainer="Polymarket Engineering",
Expand Down
2 changes: 0 additions & 2 deletions tests/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,11 @@ def test_get_config(self):
valid_config = get_contract_config(80001)
self.assertIsNotNone(valid_config)
self.assertIsNotNone(valid_config.get_exchange())
self.assertIsNotNone(valid_config.get_executor())
self.assertIsNotNone(valid_config.get_collateral())

valid_config = get_contract_config(137)
self.assertIsNotNone(valid_config)
self.assertIsNotNone(valid_config.get_exchange())
self.assertIsNotNone(valid_config.get_executor())
self.assertIsNotNone(valid_config.get_collateral())

# invalid config
Expand Down