new: hide hud #59
Merged
new: hide hud #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wyvest
requested changes
Jan 25, 2023
| return; | ||
| } | ||
|
|
||
| Arrays.asList( |
There was a problem hiding this comment.
can you use a switch statement or at least like not create the list every frame lol
There was a problem hiding this comment.
Fixed in my PR, merge mine first to the hide-hud branch
Wyvest
requested changes
Jan 25, 2023
| @@ -32,6 +32,7 @@ | |||
| public class GuiIngameForgeMixin_HideActionbar { | |||
| @Inject(method = "renderRecordOverlay", at = @At("HEAD"), cancellable = true) | |||
| private void cancelActionBar(int width, int height, float partialTicks, CallbackInfo ci) { | |||
| if (HypixelUtils.INSTANCE.isHypixel() && LocrawUtil.INSTANCE.getLocrawInfo() != null && (HytilsConfig.hideHousingActionBar && LocrawUtil.INSTANCE.getLocrawInfo().getGameType() == LocrawInfo.GameType.HOUSING) || HytilsConfig.hideDropperActionBar && LocrawUtil.INSTANCE.getLocrawInfo().getGameType() == LocrawInfo.GameType.DROPPER) ci.cancel(); | |||
There was a problem hiding this comment.
can we update this in oneconfig too
There was a problem hiding this comment.
| LocrawInfo.GameType gameType = locraw.getGameType(); | ||
| String gameMode = locraw.getGameMode(); | ||
| switch (gameType) { | ||
| case DUELS: |
There was a problem hiding this comment.
if the logic for all of this is the same (haven't seen the actual code too lazy to + on ipad) can we move this to on method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hides certain HUD elements in servers where they don’t change. This is a very old accepted Hytilities suggestion that was never realized due to its discontinuation and it always made me sad.
Things that can be hidden:
Might have work to do still (such as reverting the oneconfig gradle version) but PRing for feedback or something idk
Related Issue(s)
N/A
How to test
Join a game or lobby where you wouldn’t expect to see a certain HUD element. You should now see that it is hidden. The lobby is a good place to see all four in action. Similarly, for housing and lobby, if you were to take damage it will reintroduce the health bar.
Release Notes
Documentation