Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Cyton Status check #50

Merged
merged 68 commits into from
Oct 28, 2020
Merged

Added Cyton Status check #50

merged 68 commits into from
Oct 28, 2020

Conversation

MouradLachhab
Copy link
Contributor

Added a request for Cyton system status to make sure it is available when connecting.

Note: I have noticed that when closing by usb_serial port, I get a java.lang.InterruptedException. I have tried to catch that error or find how to avoid it without success, so if you have any idea.

image

abelfodil and others added 30 commits September 14, 2020 15:55
abelfodil
abelfodil previously approved these changes Oct 25, 2020
@abelfodil abelfodil dismissed their stale review October 25, 2020 21:16

didn't read the exception part

@MouradLachhab
Copy link
Contributor Author

MouradLachhab commented Oct 25, 2020

The exception seems to come from here:

https://github.com/felHR85/UsbSerial/blob/master/usbserial/src/main/java/com/felhr/usbserial/SerialBuffer.java#L72

https://github.com/felHR85/UsbSerial/blob/319cb9de686325dcc2814d7cbb6ed7dd36011183/usbserial/src/main/java/com/felhr/usbserial/SerialBuffer.java#L121

Yea, I've looked into it, and the latest commit for that file was exactly to fix an issue with the thread not stopping when the port was closing:
felHR85/UsbSerial@001e745

But I'm still not sure how I'm supposed to deal with this. As of right now, simply opening the port and closing it right after will trigger this exception.

Note: This exception doesn't crash the app or really have any other consequence, but I don't feel like something like that should be in the app if it can be avoided.

@MouradLachhab MouradLachhab merged commit 0474033 into master Oct 28, 2020
@MouradLachhab MouradLachhab deleted the serial branch October 28, 2020 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants