Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert hexadecimal file to decimal & feature extraction #32

Merged
merged 32 commits into from
Oct 22, 2020
Merged

Convert hexadecimal file to decimal & feature extraction #32

merged 32 commits into from
Oct 22, 2020

Conversation

conorato
Copy link
Contributor

@conorato conorato commented Oct 8, 2020 •
edited
Loading

Summary

This PR includes work to

  • Receive SD card file and converts it to a signed decimal array
  • Validates data
  • Extracts features from data provided in the file

@conorato
Copy link
Contributor Author

conorato commented Oct 8, 2020

rename backend package to classification

@conorato conorato marked this pull request as ready for review October 18, 2020 05:48
@conorato conorato changed the title [WIP] Backend/classification Convert hexadecimal file to decimal & feature extraction Oct 18, 2020
@conorato
Copy link
Contributor Author

[1.1.6.1] Classification sur le serveur

abelfodil
abelfodil requested changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@abelfodil abelfodil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall big brain stuff

Juste quelques commentaires sur la forme, sinon ça me semble correct

backend/app.py Outdated Show resolved Hide resolved
backend/requirements.txt Outdated Show resolved Hide resolved
backend/requirements.txt Outdated Show resolved Hide resolved
backend/requirements.txt Outdated Show resolved Hide resolved
backend/classification/config/constants.py Outdated Show resolved Hide resolved
backend/classification/validation.py Outdated Show resolved Hide resolved
backend/classification/config/constants.py Outdated Show resolved Hide resolved
backend/classification/validation.py Outdated Show resolved Hide resolved
backend/classification/predict.py Outdated Show resolved Hide resolved
backend/classification/features/extraction.py Outdated Show resolved Hide resolved
@conorato conorato requested a review from abelfodil October 19, 2020 03:42
abelfodil
abelfodil requested changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@abelfodil abelfodil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sinon lgtm

backend/app.py Show resolved Hide resolved
@conorato conorato requested a review from abelfodil October 19, 2020 20:12
@conorato conorato requested a review from abelfodil October 20, 2020 03:15
WilliamHarvey97
WilliamHarvey97 requested changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@WilliamHarvey97 WilliamHarvey97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Ça avance bien. Il ne manque plus qu'un dernier allez-retour au notebook et cela devrait être bon.

backend/app.py Show resolved Hide resolved
backend/classification/config/constants.py Show resolved Hide resolved
backend/classification/exceptions.py Show resolved Hide resolved
backend/classification/exceptions.py Show resolved Hide resolved
backend/classification/features/extraction.py Outdated Show resolved Hide resolved
backend/classification/file_loading.py Outdated Show resolved Hide resolved
backend/classification/file_loading.py Outdated Show resolved Hide resolved
backend/classification/features/pipeline/time_domain.py Show resolved Hide resolved
backend/classification/features/pipeline/time_domain.py Show resolved Hide resolved
backend/classification/features/extraction.py Outdated Show resolved Hide resolved
@conorato conorato mentioned this pull request Oct 20, 2020
Open
abelfodil
abelfodil requested changes Oct 20, 2020
View reviewed changes
backend/app.py Outdated Show resolved Hide resolved
backend/classification/config/constants.py Outdated Show resolved Hide resolved
@conorato conorato mentioned this pull request Oct 22, 2020
Open
@conorato conorato merged commit b2b8792 into master Oct 22, 2020
@conorato conorato deleted the backend/classification branch October 22, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelfodil abelfodil abelfodil approved these changes

@WilliamHarvey97 WilliamHarvey97 WilliamHarvey97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conorato @abelfodil @WilliamHarvey97