Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICT spec updates and WFB payload fix #282

Merged
merged 14 commits into from
Oct 9, 2024
Merged

ICT spec updates and WFB payload fix #282

merged 14 commits into from
Oct 9, 2024

Conversation

JesseMckinzie
Copy link
Member

  • Update ict spec to not require the UI component
  • Update pydantic class to only validate UI when present
  • Add function to add missing inputs in WFB payload using the links and ICT data
  • Add unit tests to for add missing WFB inputs

vjaganat90
vjaganat90 requested changes Oct 9, 2024
View reviewed changes
Copy link
Member

@vjaganat90 vjaganat90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make sure this works with conversion to clt.

src/sophios/api/utils/converter.py Outdated Show resolved Hide resolved
src/sophios/api/utils/ict/ict_spec/cast.py Show resolved Hide resolved
src/sophios/api/utils/ict/ict_spec/model.py Outdated Show resolved Hide resolved
@sameeul sameeul merged commit 11705e1 into PolusAI:master Oct 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjaganat90 vjaganat90 vjaganat90 requested changes

@sameeul sameeul sameeul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JesseMckinzie @sameeul @vjaganat90