Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Google Tests for Arrow and Parquet writers #181

Merged
merged 10 commits into from
Dec 7, 2023
Merged

Add Google Tests for Arrow and Parquet writers #181

merged 10 commits into from
Dec 7, 2023

Conversation

JesseMckinzie
Copy link
Member

  • Add C++ Google tests for Arrow and Parquet writers
  • Add Google tests for all 6 cases of get_arrow_filename
  • Fix issue with C++ locking Arrow and Parquet files from deletion

@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Dec 6, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

sameeul
sameeul reviewed Dec 6, 2023
View reviewed changes
src/nyx/output_writers.cpp Show resolved Hide resolved
tests/CMakeLists.txt Outdated Show resolved Hide resolved
@sameeul sameeul merged commit 6c26748 into PolusAI:main Dec 7, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameeul sameeul sameeul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JesseMckinzie @sameeul