-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmake update #156
Cmake update #156
Conversation
Apply Sweep Rules to your PR?
|
CMakeLists.txt
Outdated
set(USE_ARROW OFF) | ||
endif() | ||
|
||
if(BUILD_WITH_ALL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR overall. The only thing that I'd change/improve is the naming "MINIMUM_BUILD - BUILD_WITH_ALL". To me, "BUILD_WITH_ALL" sounds rather non-intuitive and not self-explanatory (Build with all the =what=?) Secondly, the pair "MINIMUM_BUILD - BUILD_WITH_ALL" is non-symmetric morphologically. Thirdly, I would stick to underscore-free flag convention as it reduces guessing whether words are separated or not. The naming natural to me would be "MINBUILD - MAXBUILD" or "NOEXTRAS - ALLEXTRAS" or so, but it's only my subjective suggestion.
CMakeList.txt
andtests/CMakeLists.txt
to streamline dependencies--min_build yes
option to install only the minimal deps.