Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dicom support #101

Merged
merged 26 commits into from
Apr 20, 2023
Merged

Dicom support #101

merged 26 commits into from
Apr 20, 2023

Conversation

sameeul
Copy link
Member

@sameeul sameeul commented Apr 13, 2023

Initial commit for for processing grayscale dicom files in Nyxus (both single frame and whole-slide image)

  • Added NyxusGrayScaleDicomLoader class
  • Modified CMakeLists.txt for including DCMTK
  • Added steps to build DCMTK and its dependencies in install_prereq_* scripts
  • Updated workflows to build wheels
  • Added dcmtk as a dependency for conda build

@hsidky hsidky requested a review from friskluft April 13, 2023 14:03
friskluft
friskluft reviewed Apr 17, 2023
View reviewed changes
Copy link
Member

@friskluft friskluft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR overall except one thing: I didn't find the point of defining preprocessor symbol 'DICOM_SUPPORT', probably overlooked I it. Samee please shed the light.
=A

CMakeLists.txt Outdated Show resolved Hide resolved
@sameeul
Copy link
Member Author

sameeul commented Apr 17, 2023

Closing it for now to fix the build issue.

@sameeul sameeul closed this Apr 17, 2023
@sameeul
Copy link
Member Author

sameeul commented Apr 17, 2023

Reopened after fixing the build issue.

@sameeul sameeul reopened this Apr 17, 2023
@sameeul sameeul requested a review from friskluft April 19, 2023 14:17
@hsidky hsidky merged commit d467206 into PolusAI:main Apr 20, 2023
@sameeul sameeul deleted the dicom_support branch August 21, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friskluft friskluft friskluft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sameeul @friskluft @hsidky