Add dynamic pyramid generation support #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/pyramid_view.cpp
Outdated
| ImageInfo whole_image; | ||
|
|
||
| if (img_count != 0) { | ||
| //std::list<tensorstore::WriteFutures> pending_writes; |
There was a problem hiding this comment.
Can this commented out code be removed?
src/pyramid_view.cpp
Outdated
| if (v == VisType::NG_Zarr | v == VisType::Viv) { | ||
| return GetZarrSpecToRead(base_zarr_path); | ||
| } else { // this will probably never happen | ||
| return tensorstore::Spec(); |
There was a problem hiding this comment.
Could there be any dangers of returning a default Spec? The comment on the tensorstore code says "Constructs an invalid specification". Maybe just log a warning if this could cause issues later on in the code path?
src/pyramid_view.cpp
Outdated
| } else if (v == VisType::Viv) { | ||
| return GetZarrSpecToWrite(output_path + "/0", new_image_shape, chunk_shape, ChooseBaseDType(base_store.dtype()).value().encoded_dtype); | ||
| } else { | ||
| return tensorstore::Spec(); |
There was a problem hiding this comment.
Same question as other tensorstore::Spec() call
JesseMckinzie
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyramidViewclass and corresponding Python bindingutilities.cpp