Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mainnet runtime updated #77

Merged
merged 1 commit into from
Jan 14, 2021
Merged

mainnet runtime updated #77

merged 1 commit into from
Jan 14, 2021

Conversation

jaxter03
Copy link
Contributor

@jaxter03 jaxter03 commented Jan 13, 2021 •
edited
Loading

Solved #18

ayushmishra2005
ayushmishra2005 reviewed Jan 13, 2021
View reviewed changes
runtime/mainnet/src/lib.rs
Staking: pallet_staking::{Module, Call, Config<T>, Storage, Event<T>, ValidateUnsigned},
Session: pallet_session::{Module, Call, Storage, Event, Config<T>},
Historical: pallet_session_historical::{Module},
// Include the custom logic from the polkadex pallet in the runtime.
Polkadex: polkadex::{Module, Call, Storage, Event<T>},
PolkadexUniswap: polkadex_swap_engine::{Module, Call, Storage, Event<T>},
PolkadexIdentity: pallet_idenity::{Module, Call, Storage, Event<T>},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the formatting here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not showing on IDE.
Screenshot from 2021-01-13 17-04-12

runtime/mainnet/src/lib.rs
@@ -647,32 +671,32 @@ impl_runtime_apis! {

impl runtime_api::DexStorageApi<Block> for Runtime{

fn get_ask_level(trading_pair: Hash) -> Result<Vec<FixedU128>,ErrorRpc> {
fn get_ask_level(trading_pair: (Hash,Hash)) -> Result<Vec<FixedU128>,ErrorRpc> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting issue

@ayushmishra2005 ayushmishra2005 self-requested a review January 13, 2021 11:23
@jaxter03
Copy link
Contributor Author

Please Review the PR for Mainnet upgradation.

@jaxter03 jaxter03 merged commit c056193 into develop Jan 14, 2021
@jaxter03 jaxter03 deleted the feature/18-impl-cust-asset branch January 14, 2021 04:35
@Gauthamastro Gauthamastro linked an issue Jan 18, 2021 that may be closed by this pull request
Swap GenericAssets with Polkadex Assets Pallet #18
Closed
@Gauthamastro Gauthamastro mentioned this pull request Jan 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauthamastro Gauthamastro Gauthamastro approved these changes

@ayushmishra2005 ayushmishra2005 Awaiting requested review from ayushmishra2005

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swap GenericAssets with Polkadex Assets Pallet
3 participants
@jaxter03 @ayushmishra2005 @Gauthamastro