fix: set profile to default on removing the last member of a profile

[Nick-1979]

close #1533

Summary by CodeRabbit

• New Features

  • Enhanced profile management with the ability to dynamically track and display the currently selected profile.
  • Improved logic for profile removal, ensuring a more intuitive user experience when managing profiles.

• Bug Fixes

  • Refined handling of profile removal to prevent inconsistencies when the last associated profile is deleted.

[coderabbitai]

Walkthrough

The changes in this pull request enhance the ProfileMenu component by adding state management for the currently selected profile and refining the profile removal logic. A new state variable, currentProfile, is introduced, and the component now retrieves the current profile from storage upon mounting. The logic for handling profile removal has been improved to ensure that if the last profile is removed, the default profile tag is set to PROFILE_TAGS.ALL.

Changes

File	Change Summary
packages/extension-polkagate/src/fullscreen/homeFullScreen/partials/ProfileMenu.tsx	Added state management for the current profile and improved logic for profile removal.

Assessment against linked issues

Objective	Addressed	Explanation
when the last account in a user defined profile removes its profile the current tabs needs to be switched to a default one like ALL (#1533)	✅

Possibly related PRs

• fix: address the issue where account menu remains open on remove profile in extension mode #1532: Modifications to props and internal logic in ProfileMenu.tsx that relate to profile management.

Poem

🐰 In the garden of profiles, we hop with glee,
Removing the last, we set tags free.
With a flick of a tail, and a jump so spry,
To PROFILE_TAGS.ALL, we say goodbye!
Changes abound, our menu's refined,
A smoother experience, for all of humankind! 🌼

Tip

New features

Walkthrough comment now includes:

• Possibly related PRs: A list of potentially related PRs to help you recall past context.
• Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs. You can also provide custom labeling instructions in the UI or configuration file.

Notes:

• Please share any feedback in the discussion post on our Discord.
• Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Outside diff range, codebase verification and nitpick comments (1)

packages/extension-polkagate/src/fullscreen/homeFullScreen/partials/ProfileMenu.tsx (1)

Line range hint 223-247: Approved modifications in onRemove but consider using optional chaining.

The modifications in the onRemove function align with the PR objectives. Consider using optional chaining for better safety and readability in accessing nested properties, as suggested by static analysis.

Tools

Biome

[error] 229-229: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 174e174 and 0f7679d.

Files selected for processing (1)

• packages/extension-polkagate/src/fullscreen/homeFullScreen/partials/ProfileMenu.tsx (4 hunks)

Additional context used

Biome

packages/extension-polkagate/src/fullscreen/homeFullScreen/partials/ProfileMenu.tsx

[error] 229-229: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

Additional comments not posted (2)

packages/extension-polkagate/src/fullscreen/homeFullScreen/partials/ProfileMenu.tsx (2)

11-13: Approved import changes.

The new imports for getStorage, setStorage, and PROFILE_TAGS are essential for the updated profile management functionality.

---

196-196: Approved addition of currentProfile state variable.

The introduction of the currentProfile state variable is crucial for managing the current profile state across the component.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0f7679d and 4447b66.

Files selected for processing (1)

• packages/extension-polkagate/src/fullscreen/homeFullScreen/partials/ProfileMenu.tsx (3 hunks)

Files skipped from review as they are similar to previous changes (1)

• packages/extension-polkagate/src/fullscreen/homeFullScreen/partials/ProfileMenu.tsx